feat: modernize Switch to MD3#4957
Open
adrcotfas wants to merge 3 commits into
Open
Conversation
|
The mobile version of example app from this branch is ready! You can see it here. |
satya164
requested changes
May 24, 2026
adrcotfas
force-pushed
the
@adrcotfas/tokens_structure
branch
from
91d86b4 to
be1c417
Compare
adrcotfas
force-pushed
the
@adrcotfas/tokens_structure
branch
from
be1c417 to
b41006a
Compare
adrcotfas
force-pushed
the
@adrcotfas/switch
branch
from
562f947 to
7731d0e
Compare
adrcotfas
force-pushed
the
@adrcotfas/tokens_structure
branch
from
b41006a to
f675baf
Compare
adrcotfas
force-pushed
the
@adrcotfas/switch
branch
from
7731d0e to
9e41a0b
Compare
Collaborator
Author
|
@satya164 Findings were fixed. I discovered an issue with the dynamic theme when testing custom switch colors and applied a fix as a separate commit. |
satya164
requested changes
May 26, 2026
Member
satya164
left a comment
satya164
left a comment
There was a problem hiding this comment.
Quickly clicking on the Switch feels bad, probably because the Switch grows and changes position unanimated before the animation is visible
CleanShot.2026-05-26.at.17.00.57-optimised.mp4
RTL seems to be broken on Web
CleanShot.2026-05-26.at.16.39.44-optimised.mp4
I've merged some updates to main which should let you toggle RTL on Web for testing
adrcotfas
force-pushed
the
@adrcotfas/switch
branch
from
9e41a0b to
ff68912
Compare
Collaborator
Author
It should be fine now.
Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Update the Switch to use the latest MD specs, including motion and RTL.
Related issue
Closes #4939
Partially closes #4892
Test plan
Demo
Screen_recording_20260520_171630.webm
Simulator.Screen.Recording.-.iPhone.16e.-.2026-05-20.at.17.46.36.mov